-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(DMN): add hints on the returned Java types #286
Conversation
Thanks for your PR. Just based on the code you submitted (without any explaination) it is not quite clear what you would you like to achieve. Could you elaborate why this is an improvement (from the user perspective)? |
Sorry for my brevity while opening this live during a customer workshop. In consulting, we frequently experience that customers do not understand the result mapping and what they can expect from the different settings. In our developer trainings, we explain that with the resulting Java types. So the next logical step was to put that type hint also into the labels shown in the property panel. That way users can decide easier and don't have to search the docs or write unit tests in order to figure it out. |
To give even more context: |
As an alternative to your solution we could simply link the docs, too. Which solution would you prefer? |
Both. |
I guess, this would be the right link to put: https://docs.camunda.org/manual/latest/user-guide/process-engine/decisions/bpmn-cmmn/#predefined-mapping-of-the-decision-result Nevertheless, we could save people some time by directly putting the hints in the labels, which are not exactly self-explanatory. |
Should this already be available in 3.0.0-nightly builds? I didn't see it there. |
We do not properly sanitize element labels we build the UI from: https://github.com/bpmn-io/bpmn-js-properties-panel/blob/master/lib/factory/SelectEntryFactory.js#L51 This means that entities such as |
I've created #296 to track the bug. |
Is there anything that I can do as a workaround until #296 is fixed?
|
Unfortunately not. We scheduled #296 this as a bug in our next milestone. |
No description provided.