-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localize literals, which are not yet localized. #295
Conversation
I also changed in some places |
lib/provider/bpmn/parts/implementation/ConditionalEventDefinition.js
Outdated
Show resolved
Hide resolved
First and foremost thank you for your pull request! :) I left a few comments in the code. Please make sure that you adhere to our commit guidlines, which are linked in the CONTRIBUTING.md file. |
Thank you for review of this PR. I made a new commit with changes, which address (I hope) your remarks. |
Squashed and force-pushed it back to the branch. Hope I did not screw it up. :) |
Thanks! Just one more thing: Can you modify your commit message to fit our guideline? It would be something like
You could even consider splitting the commit into 2 or 3 since (as you described above, cf. #295 (comment)) there are different things achieved inside your pull request. However, @barmac can you have a look at whether the made changes fit your requests? |
Changed commit message as per recommendation of Niklas Kiefer. If you see that it is not ok, could you please be more specific how exactly you would like to split it into several? |
I've added a few more comments. Let's fix this, as we're close to merge :) |
Resolved both findings. Also, found some 2 more options list - localized them too (those are execution and task listener event types). |
I added one more commit dedicated to translation of element template. |
Localized list of templates, labels of template fields, validation messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you for your contribution! 🚀
Guys, do you have any idea on when (or if) you plan to publish it? |
Sure, it's now published in v0.30.0. |
Thank you! |
Closes #297