Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(properties-panel): crop descriptions #370

Merged
merged 1 commit into from
Oct 5, 2020
Merged

feat(properties-panel): crop descriptions #370

merged 1 commit into from
Oct 5, 2020

Conversation

philippfromme
Copy link
Contributor

@philippfromme philippfromme commented Sep 28, 2020 •
edited
Loading

Which issue does this PR address?

Related to camunda/camunda-modeler#1954
Closes #369

Acceptance Criteria

  • Corresponds to the concept
  • Corresponds to the design

Definition of Done

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Sep 28, 2020
pinussilvestrus
pinussilvestrus suggested changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@pinussilvestrus pinussilvestrus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Descriptions inside entries related to the new collapsible item are not properly collapsed. Cf.

Start typing "{}" ...

image

image

I guess this is related to the auto suggest factory

Bildschirmfoto 2020-09-29 um 16 00 11

@philippfromme philippfromme force-pushed the 369-crop-descriptions branch 3 times, most recently from 8ad3fe8 to 9afcc87 Compare October 1, 2020 09:00
@pinussilvestrus pinussilvestrus mentioned this pull request Oct 1, 2020
Closed
@pinussilvestrus
Copy link
Contributor

pinussilvestrus commented Oct 2, 2020 •
edited
Loading

Are there any changes needed in the Camunda Modeler? When I open the Modeler on develop with this branch, the Modeler is crashing when opening the Properties Panel:

image

Also, one test is failing on Travis, because we also need to update the description for ToggleSwitchFactory. This was just added yesterday, sorry for the noise 😅

@pinussilvestrus
Copy link
Contributor

Are there any changes needed in the Camunda Modeler? When I open the Modeler on develop with this branch, the Modeler is crashing when opening the Properties Panel:

image

Ah, got it, it's due to breaking changes in the entryFactory.link API, cf. https://github.com/camunda/camunda-modeler/blob/develop/client/src/plugins/element-templates-modal/modeler/PropertiesProvider.js#L61

philippfromme added a commit to camunda/camunda-modeler that referenced this pull request Oct 2, 2020
@philippfromme
chore(element-templates-modal): update API
7bf7e90 
Related to bpmn-io/bpmn-js-properties-panel#370
@philippfromme philippfromme mentioned this pull request Oct 2, 2020
Merged
9 tasks
@philippfromme
Copy link
Contributor Author

Ah, got it, it's due to breaking changes in the entryFactory.link API, cf. https://github.com/camunda/camunda-modeler/blob/develop/client/src/plugins/element-templates-modal/modeler/PropertiesProvider.js#L61

Yes, exactly, I created camunda/camunda-modeler#1954 for that.

@pinussilvestrus
Copy link
Contributor

Should we mark these changes as breaking then?

@philippfromme philippfromme force-pushed the 369-crop-descriptions branch 2 times, most recently from 0821df0 to 9755d04 Compare October 5, 2020 07:58
@philippfromme
feat(properties-panel): crop descriptions
c6e7e76 
BREAKING CHANGES

* all factories now return DOM instead of string
* API of all factories has changed and now requires `translate` as first parameter

Closes #369


feat(entry-field-description): make translate first parameter
@pinussilvestrus pinussilvestrus merged commit fbca3fe into master Oct 5, 2020
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 5, 2020
@fake-join fake-join bot deleted the 369-crop-descriptions branch October 5, 2020 12:39
pinussilvestrus pushed a commit to camunda/camunda-modeler that referenced this pull request Oct 6, 2020
@philippfromme
chore(element-templates-modal): update API
e2d7f44 
Related to bpmn-io/bpmn-js-properties-panel#370
oguzeroglu pushed a commit to camunda/camunda-modeler that referenced this pull request Oct 7, 2020
@philippfromme @oguzeroglu
chore(element-templates-modal): update API
bd35397 
Related to bpmn-io/bpmn-js-properties-panel#370
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barmac barmac barmac left review comments

@pinussilvestrus pinussilvestrus pinussilvestrus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crop description for descriptions of element-template field
3 participants
@philippfromme @pinussilvestrus @barmac