feat(cloud): allow setting custom form key

[smbea]

Related to camunda/camunda-modeler#2759

[MaxTru]

I can break this when using undo:

1. Select Camunda Forms
2. Do Undo
3. => weird state
   

[smbea]

It was a small issue with the commands executed with the command stack -> fixed

[MaxTru]

For all test cases I miss a should react to external changes (e.g. like undo). This should hvae then also catched the bug I reported before.

[MaxTru]

You always push the two input components, and they then may return undefined if no applicable.

Would it not make more sense to check whether they are applicable already here?

E.g., have if (isCamundaForm(element, formHelper)) directly here.

[smbea]

I did this because I got an error when trying to do injector.invoke(FormHelper) in the main component FormProps: unhandled error in event listener TypeError: Cannot read properties of null (reading 'invoke'). Do you know why this might happen?

[nikku]

injector is not defined, that is what the error says.

[smbea]

But I'm trying to do:

const injector = useService('injector');
const formHelper = injector.invoke(FormHelper);

Like I do in the other components, and only on the main one I get that error.

[nikku]

Could you check-in a failing test case? I'm happy to have a look.

[smbea]

I added a test branch with these changes). More specifically:

bpmn-js-properties-panel/src/provider/zeebe/properties/FormProps.js

Line 41 in 84b067a

const formHelper = injector.invoke(FormHelper);

This causes a bunch of tests to fail because it throws the error I mentioned.

[smbea]

I was able to figure out the issue with the injector and formHelper. Reopened for review (@MaxTru)

[MaxTru]

👏