-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(element-template): copy versioned elementTemplate #632
Conversation
c3daa44
to
f09f278
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gave this PR a second thought: Given our future direction on "element template configured elements being first class citizens on the diagram" you could argue that replacing from service task to user task shall always unlink the template.
We'll otherwise end up in a situation where I cannot get rid of a template via replace anymore; in some contexts thought replace is the only thing we got (i.e. web-modeler).
So TLDR: If we introduce "retain template" as a feature here I'd rather keep "remove template during replace".
Does this make sense @marstamm @pinussilvestrus @MaxTru? Happy to provide further details on this.
Just to clarify: this is already existing behavior for element templates. We did not introduce something new here. It was just broken if the element had a version - therefore being inconsistent depending on which element template was applied. I would propose to move the discussion if we want to change this behavior in a dedicated issue. In the current scope of Element Templates inside the properties panel, this behavior also makes sense as we have a dedicated unlink button for it. |
Makes sense @marstamm. Will open that separate issue. |
Follow up on #632 (review): #642 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as intended.
closes #631