Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(element-template): copy versioned elementTemplate #632

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

marstamm
Copy link
Contributor

Recording 2022-03-28 at 14 20 25

closes #631

@marstamm marstamm requested review from pinussilvestrus and a team March 28, 2022 12:23
@marstamm marstamm self-assigned this Mar 28, 2022
@marstamm marstamm requested review from MaxTru and removed request for a team March 28, 2022 12:23
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Mar 28, 2022
@nikku

This comment was marked as off-topic.

@nikku nikku self-requested a review March 29, 2022 13:32
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave this PR a second thought: Given our future direction on "element template configured elements being first class citizens on the diagram" you could argue that replacing from service task to user task shall always unlink the template.

We'll otherwise end up in a situation where I cannot get rid of a template via replace anymore; in some contexts thought replace is the only thing we got (i.e. web-modeler).

So TLDR: If we introduce "retain template" as a feature here I'd rather keep "remove template during replace".

Does this make sense @marstamm @pinussilvestrus @MaxTru? Happy to provide further details on this.

@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Mar 29, 2022
@marstamm
Copy link
Contributor Author

If we introduce "retain template" as a feature here I'd rather keep "remove template during replace"

Just to clarify: this is already existing behavior for element templates. We did not introduce something new here. It was just broken if the element had a version - therefore being inconsistent depending on which element template was applied.

I would propose to move the discussion if we want to change this behavior in a dedicated issue. In the current scope of Element Templates inside the properties panel, this behavior also makes sense as we have a dedicated unlink button for it.

@nikku
Copy link
Member

nikku commented Mar 29, 2022

Makes sense @marstamm. Will open that separate issue.

@nikku
Copy link
Member

nikku commented Mar 29, 2022

Follow up on #632 (review): #642

@nikku nikku self-requested a review March 29, 2022 14:42
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended.

@fake-join fake-join bot merged commit 1d0d525 into master Mar 29, 2022
@fake-join fake-join bot deleted the fix-replace-behavior branch March 29, 2022 14:42
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Element Template Replace behavior is broken for versioned templates
3 participants