Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloud-templates): move modelerTemplateIcon to property #658

Merged
merged 2 commits into from
Apr 5, 2022

Conversation

marstamm
Copy link
Contributor

@marstamm marstamm commented Apr 5, 2022

try it out with

npx @bpmn-io/sr bpmn-io/bpmn-js-properties-panel#templateIcon-as-property -c "npm run start:cloud-templates"

Recording 2022-04-05 at 15 18 08

- `@bpmn-io/element-templates-icons-renderer@0.1.2`
- `zeebe-bpmn-moddle@0.12.1`
@marstamm marstamm self-assigned this Apr 5, 2022
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Apr 5, 2022
@marstamm
Copy link
Contributor Author

marstamm commented Apr 5, 2022

I also checked that the deployment works, but only on Zeebe 1.3.6 (latest in production). Is there an easy way to check for Zeebe 8?

@MaxTru
Copy link
Contributor

MaxTru commented Apr 5, 2022

I also checked that the deployment works, but only on Zeebe 1.3.6 (latest in production). Is there an easy way to check for Zeebe 8?

I am able to select alpha channel in cloud:

Screenshot_20220405_153424

Does this work for you?

@marstamm
Copy link
Contributor Author

marstamm commented Apr 5, 2022

Ah, I have to delete my old cluster for it. Yes, that works 👍

@MaxTru
Copy link
Contributor

MaxTru commented Apr 5, 2022

I also deployed a testFile to 1.4.-alpha (outside of this PR) with success (no deploy error)

properties: {
body: contents
}
modeling.updateProperties(element, {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much simpler even :-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, how easy it is to handle attributes instead of complex extension elements 🙂

Copy link
Contributor

@MaxTru MaxTru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@fake-join fake-join bot merged commit 3bff6ed into master Apr 5, 2022
@fake-join fake-join bot deleted the templateIcon-as-property branch April 5, 2022 13:40
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants