Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(render): use template version #670

Merged
merged 1 commit into from
Apr 22, 2022
Merged

Conversation

pinussilvestrus
Copy link
Contributor

Related to camunda/camunda-modeler#2920

In the properties panel header, it now uses the template version as well to retrieve the applied template.

Camunda Platform 8

image

Camunda Platform 7

image

Copy link
Contributor

@marstamm marstamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be simplified further: elementTemplates.get returns null when no template is set

src/render/PanelHeaderProvider.js Outdated Show resolved Hide resolved
src/render/PanelHeaderProvider.js Outdated Show resolved Hide resolved
@fake-join fake-join bot merged commit 1e5c414 into master Apr 22, 2022
@fake-join fake-join bot deleted the 2920-versioned-templates-header branch April 22, 2022 13:18
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants