-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Behavior Integration Tests #671
Conversation
d9fc892
to
4da295f
Compare
4da295f
to
1cb4dab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty cool stuff 👏 👏
I first thought that maybe undo/redo tests would be nice on top, but since we are anyway doing it in the behaviors project, I think it's fine.
@@ -314,6 +322,311 @@ describe('provider/zeebe - OutputPropagationProps', function() { | |||
expect(getCalledElement(callActivity)).to.exist; | |||
})); | |||
|
|||
|
|||
describe('integration', function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that we do additionally undo/redo testing here to ensure the UI interaction works as expected 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about undo/redo tests but we're merely integration testing things here. In camunda-bpmn-js-behaviors
we've got all of that covered thoroughly.
Adds integration tests for https://github.com/camunda/camunda-bpmn-js-behaviors.
Related to https://github.com/bpmn-io/internal-docs/issues/404