Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Behavior Integration Tests #671

Merged
merged 11 commits into from
Apr 21, 2022
Merged

Add Behavior Integration Tests #671

merged 11 commits into from
Apr 21, 2022

Conversation

philippfromme
Copy link
Contributor

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Apr 20, 2022
@philippfromme philippfromme marked this pull request as ready for review April 21, 2022 14:12
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Apr 21, 2022
Copy link
Contributor

@pinussilvestrus pinussilvestrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty cool stuff 👏 👏

I first thought that maybe undo/redo tests would be nice on top, but since we are anyway doing it in the behaviors project, I think it's fine.

@@ -314,6 +322,311 @@ describe('provider/zeebe - OutputPropagationProps', function() {
expect(getCalledElement(callActivity)).to.exist;
}));


describe('integration', function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that we do additionally undo/redo testing here to ensure the UI interaction works as expected 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about undo/redo tests but we're merely integration testing things here. In camunda-bpmn-js-behaviors we've got all of that covered thoroughly.

@fake-join fake-join bot merged commit 6742f50 into master Apr 21, 2022
@fake-join fake-join bot deleted the 404-remove-behaviors branch April 21, 2022 15:25
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants