Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not render non-existing values #676

Merged
merged 1 commit into from
May 6, 2022
Merged

fix: do not render non-existing values #676

merged 1 commit into from
May 6, 2022

Conversation

nikku
Copy link
Member

@nikku nikku commented May 6, 2022

Closes #675

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label May 6, 2022
@nikku
Copy link
Member Author

nikku commented May 6, 2022 •
edited
Loading

I'm really not sure why we had the original behavior (#675) there in the first place. It is missleading to our users as far as I see.

Would love you to double check that @barmac @pinussilvestrus @MaxTru.

@nikku nikku requested a review from MaxTru May 6, 2022 11:58
barmac
barmac approved these changes May 6, 2022
View reviewed changes
Copy link
Member

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think the previous behavior was just a bug.

@fake-join fake-join bot merged commit c0b717c into master May 6, 2022
@fake-join fake-join bot deleted the 675-default-binding-value branch May 6, 2022 13:27
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barmac barmac barmac approved these changes

@pinussilvestrus pinussilvestrus Awaiting requested review from pinussilvestrus

@MaxTru MaxTru Awaiting requested review from MaxTru

Assignees

@nikku nikku

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default binding value is shown, where non is configured
2 participants
@nikku @barmac