Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separator to process variable sources #714

Merged
merged 2 commits into from
Jul 4, 2022

Conversation

smbea
Copy link
Contributor

@smbea smbea commented Jul 1, 2022

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jul 1, 2022
@smbea smbea requested review from a team, pinussilvestrus, barmac and Skaiir and removed request for a team and pinussilvestrus July 1, 2022 14:51
@barmac
Copy link
Member

barmac commented Jul 4, 2022

I can't test right now because of an error when I try to add a subprocess:

image

This seems to be caused by an incompatible combination of bpmn-js and diagram-js. Namely, we use bpmn-js@9.2.2 with diagram-js@8.1.1 even though the former library requires diagram-js@8.3.0 for the hit boxes improvements.

I will push an update to the PR.

Copy link
Member

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

@fake-join fake-join bot merged commit d1d6235 into master Jul 4, 2022
@fake-join fake-join bot deleted the separate-process-var-sources branch July 4, 2022 06:38
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants