Explicitly bind undo/redo shortcuts to properties container #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpmn-io-tasks
bot
added
in progress
nikku
force-pushed
the
explicit-undo-redo
branch
from
039530d
to
40853ed
Compare
This prepares for bpmn-io/diagram-js#662, but is built in a way that is backwards compatible.
nikku
force-pushed
the
explicit-undo-redo
branch
2 times, most recently
from
9432f4e
to
4233a85
Compare
bpmn-io-tasks
bot
added
needs review
…e manner We shall rely on bpmn-js behaviors to wire the group element with the diagrams underlying `bpmn:Definitions` object.
nikku
force-pushed
the
explicit-undo-redo
branch
from
4233a85
to
d801ccf
Compare
|
Works against all recent bpmn-js + diagram-js versions as well as |
nikku
changed the title
nikku
force-pushed
the
explicit-undo-redo
branch
from
d801ccf
to
ad8686d
Compare
|
Please give this a review @marstamm @philippfromme |
marstamm
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows bpmn-io/diagram-js#662 and adds explicit handling of undo/redo keyboard shortcuts on the properties panel to trigger diagram undo/redo.
Depends on bpmn-io/diagram-js#665 and backports (bpmn-io/diagram-js#664, bpmn-io/diagram-js#663)