fix(ImplementationProps): don't remove empty properties

src/provider/camunda-platform/properties/DmnImplementationProps.js

@@ -108,7 +108,7 @@ function DecisionRef(props) {
       element,
       moddleElement: businessObject,
       properties: {
-        'camunda:decisionRef': value
+        'camunda:decisionRef': value || ''
       }
     });
   };

src/provider/camunda-platform/properties/ImplementationProps.js

@@ -104,7 +104,7 @@ export function JavaClass(props) {
       element,
       moddleElement: businessObject,
       properties: {
-        'camunda:class': value
+        'camunda:class': value || ''
       }
     });
   };
@@ -139,7 +139,7 @@ export function Expression(props) {
       element,
       moddleElement: businessObject,
       properties: {
-        'camunda:expression': value
+        'camunda:expression': value || ''
       }
     });
   };
@@ -207,7 +207,7 @@ export function DelegateExpression(props) {
       element,
       moddleElement: businessObject,
       properties: {
-        'camunda:delegateExpression': value
+        'camunda:delegateExpression': value || ''
       }
     });
   };

src/provider/camunda-platform/properties/ListenerProps.js

@@ -382,6 +382,9 @@ function ImplementationDetails(props) {
   } else if (type === 'script') {
     return ScriptProps({ element, script: listener.get('script'), prefix: idPrefix });
   }
+
+  // should never happen
+  return [];
 }
 
 function EventTypeDetails(props) {

test/spec/provider/camunda-platform/DmnImplementationProps.spec.js

@@ -119,6 +119,29 @@ describe('provider/camunda-platform - DmnImplementationProps', function() {
     }));
 
 
+    it('should NOT delete property on empty value', inject(async function(elementRegistry, selection) {
+
+      // given
+      const businessRuleTask = elementRegistry.get('BusinessRuleTask_dmn');
+
+      await act(() => {
+        selection.select(businessRuleTask);
+      });
+
+      const input = domQuery('input[name=decisionRef]', container);
+      changeInput(input, 'newValue');
+
+      // when
+      changeInput(input, '');
+
+      // then
+      const decisionRef = getBusinessObject(businessRuleTask).get('camunda:decisionRef');
+
+      expect(decisionRef).to.exist;
+      expect(decisionRef).to.eql('');
+    }));
+
+
     it('should update on external change',
       inject(async function(elementRegistry, selection, commandStack) {
 

test/spec/provider/camunda-platform/ImplementationProps.spec.js

@@ -122,6 +122,29 @@ describe('provider/camunda-platform - ImplementationProps', function() {
     }));
 
 
+    it('should NOT delete property on empty value', inject(async function(elementRegistry, selection) {
+
+      // given
+      const serviceTask = elementRegistry.get('ServiceTask_class');
+
+      await act(() => {
+        selection.select(serviceTask);
+      });
+
+      const input = domQuery('input[name=javaClass]', container);
+      changeInput(input, 'newValue');
+
+      // when
+      changeInput(input, '');
+
+      // then
+      const camundaClass = getBusinessObject(serviceTask).get('camunda:class');
+
+      expect(camundaClass).to.exist;
+      expect(camundaClass).eql('');
+    }));
+
+
     it('should update on external change',
       inject(async function(elementRegistry, selection, commandStack) {
 
@@ -216,6 +239,29 @@ describe('provider/camunda-platform - ImplementationProps', function() {
     }));
 
 
+    it('should NOT delete property on empty value', inject(async function(elementRegistry, selection) {
+
+      // given
+      const serviceTask = elementRegistry.get('ServiceTask_class');
+
+      await act(() => {
+        selection.select(serviceTask);
+      });
+
+      const input = domQuery('input[name=javaClass]', container);
+      changeInput(input, 'newValue');
+
+      // when
+      changeInput(input, '');
+
+      // then
+      const camundaClass = getBusinessObject(serviceTask).get('camunda:class');
+
+      expect(camundaClass).to.exist;
+      expect(camundaClass).eql('');
+    }));
+
+
     it('should update on external change',
       inject(async function(elementRegistry, selection, commandStack) {
 
@@ -310,6 +356,29 @@ describe('provider/camunda-platform - ImplementationProps', function() {
     }));
 
 
+    it('should NOT delete property on empty value', inject(async function(elementRegistry, selection) {
+
+      // given
+      const serviceTask = elementRegistry.get('ServiceTask_expression');
+
+      await act(() => {
+        selection.select(serviceTask);
+      });
+
+      const input = domQuery('input[name=expression]', container);
+      changeInput(input, 'newValue');
+
+      // when
+      changeInput(input, '');
+
+      // then
+      const expression = getBusinessObject(serviceTask).get('camunda:expression');
+
+      expect(expression).to.exist;
+      expect(expression).eql('');
+    }));
+
+
     it('should update on external change',
       inject(async function(elementRegistry, selection, commandStack) {
 
@@ -404,6 +473,29 @@ describe('provider/camunda-platform - ImplementationProps', function() {
     }));
 
 
+    it('should NOT delete property on empty value', inject(async function(elementRegistry, selection) {
+
+      // given
+      const messageEvent = elementRegistry.get('MessageEndEvent_Expression');
+
+      await act(() => {
+        selection.select(messageEvent);
+      });
+
+      const input = domQuery('input[name=expression]', container);
+      changeInput(input, 'newValue');
+
+      // when
+      changeInput(input, '');
+
+      // then
+      const expression = getServiceTaskLikeBusinessObject(messageEvent).get('camunda:expression');
+
+      expect(expression).to.exist;
+      expect(expression).eql('');
+    }));
+
+
     it('should update on external change',
       inject(async function(elementRegistry, selection, commandStack) {
 
@@ -688,6 +780,29 @@ describe('provider/camunda-platform - ImplementationProps', function() {
     }));
 
 
+    it('should NOT delete property on empty value', inject(async function(elementRegistry, selection) {
+
+      // given
+      const serviceTask = elementRegistry.get('ServiceTask_delegateExpression');
+
+      await act(() => {
+        selection.select(serviceTask);
+      });
+
+      const input = domQuery('input[name=delegateExpression]', container);
+      changeInput(input, 'newValue');
+
+      // when
+      changeInput(input, '');
+
+      // then
+      const delegateExpression = getBusinessObject(serviceTask).get('camunda:delegateExpression');
+
+      expect(delegateExpression).to.exist;
+      expect(delegateExpression).eql('');
+    }));
+
+
     it('should update on external change',
       inject(async function(elementRegistry, selection, commandStack) {
 
@@ -784,6 +899,29 @@ describe('provider/camunda-platform - ImplementationProps', function() {
     }));
 
 
+    it('should NOT delete property on empty value', inject(async function(elementRegistry, selection) {
+
+      // given
+      const messageEvent = elementRegistry.get('MessageEndEvent_DelegateExpression');
+
+      await act(() => {
+        selection.select(messageEvent);
+      });
+
+      const input = domQuery('input[name=delegateExpression]', container);
+      changeInput(input, 'newValue');
+
+      // when
+      changeInput(input, '');
+
+      // then
+      const delegateExpression = getServiceTaskLikeBusinessObject(messageEvent).get('camunda:delegateExpression');
+
+      expect(delegateExpression).to.exist;
+      expect(delegateExpression).eql('');
+    }));
+
+
     it('should update on external change',
       inject(async function(elementRegistry, selection, commandStack) {