Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove properties panel css #958

Merged
merged 4 commits into from
Aug 24, 2023
Merged

Remove properties panel css #958

merged 4 commits into from
Aug 24, 2023

Conversation

marstamm
Copy link
Contributor

@marstamm marstamm commented Aug 24, 2023

This helps us streamline our release process and prevents css mismatches in downstream libraries.

Related Slack discussion: https://camunda.slack.com/archives/GP70M0J6M/p1692870672157409

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Aug 24, 2023
@marstamm marstamm marked this pull request as ready for review August 24, 2023 11:49
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Aug 24, 2023
@marstamm marstamm requested review from a team, philippfromme and smbea and removed request for a team August 24, 2023 11:49
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think this more clearly separates things; and if you want a "bundle", then camunda-bpmn-js or other projects are your go-to place.

@marstamm marstamm merged commit bf88af2 into master Aug 24, 2023
9 checks passed
@marstamm marstamm deleted the remove-properties-panel-css branch August 24, 2023 12:00
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants