Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEEL): use moddle element to filter for variables #984

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

marstamm
Copy link
Contributor

@marstamm marstamm commented Oct 11, 2023

We added this functionality to the variable resolver a while back but never properly integrated it. Ooops. Better late than never I guess.

image

related to camunda/camunda-modeler#3510

@marstamm marstamm requested a review from a team October 11, 2023 09:04
@marstamm marstamm self-assigned this Oct 11, 2023
@marstamm marstamm requested review from smbea and barmac and removed request for a team October 11, 2023 09:04
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Oct 11, 2023
Comment on lines 60 to 62
getVariablesForElement: bo => getVariablesForElement(bo)
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This made me wonder if it's not a bug. const and let variables are not hoisted, so theoretically if one calls withVariableContext immediately after import, the variable may throw error of access before initialisation. I guess it's not a problem since the CI is passing, but I'd rather expect such defaults to be declared on top of the file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better be safe and move it back up 🙈

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do it.

@barmac barmac merged commit 2aef21e into main Oct 11, 2023
8 checks passed
@barmac barmac deleted the filter-available-variables branch October 11, 2023 12:04
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants