Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Log): add aria-label to close button #178

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

marstamm
Copy link
Contributor

Proposed Changes

Make close button accessible.

closes #177

Steps to reproduce:

  • check out branch
  • open log
  • check AXE dev tools
  • no Buttons must have discernible Text Issue is shown

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached No visual changes
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@marstamm marstamm requested review from barmac, a team and philippfromme and removed request for a team June 17, 2024 11:11
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jun 17, 2024
@marstamm marstamm merged commit 42c8d00 into main Jun 17, 2024
8 checks passed
@marstamm marstamm deleted the 177-add-close-button-label branch June 17, 2024 11:55
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add label to the token simulation log close button
2 participants