fix: support core replace in compensation behavior

Closes #2073
bpmn-io · Jan 9, 2024 · 11fef5f · 11fef5f
1 parent d88a46e
commit 11fef5f
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 6 deletions.
diff --git a/lib/features/modeling/behavior/CompensateBoundaryEventBehavior.js b/lib/features/modeling/behavior/CompensateBoundaryEventBehavior.js
@@ -92,13 +92,15 @@ export default function CompensateBoundaryEventBehavior(eventBus, modeling, bpmn
    * and remove the potential candidates for connection replacement to have a single compensation activity.
    */
   function handleReplacement(context) {
-    const { targetElement } = context.hints || {},
-          { oldShape } = context;
+    const {
+      newData,
+      oldShape
+    } = context;
 
     // from compensate boundary event
     if (isCompensationBoundaryEvent(context.oldShape) &&
-      targetElement.eventDefinitionType !== 'bpmn:CompensateEventDefinition' ||
-      targetElement.type !== 'bpmn:BoundaryEvent'
+      newData.eventDefinitionType !== 'bpmn:CompensateEventDefinition' ||
+      newData.type !== 'bpmn:BoundaryEvent'
     ) {
       const targetConnection = oldShape.outgoing.find(
         ({ target }) => isForCompensation(target)
@@ -112,8 +114,8 @@ export default function CompensateBoundaryEventBehavior(eventBus, modeling, bpmn
     // to compensate boundary event
     else if (
       !isCompensationBoundaryEvent(context.oldShape) &&
-      targetElement.eventDefinitionType === 'bpmn:CompensateEventDefinition' &&
-      targetElement.type === 'bpmn:BoundaryEvent'
+      newData.eventDefinitionType === 'bpmn:CompensateEventDefinition' &&
+      newData.type === 'bpmn:BoundaryEvent'
     ) {
       const targetConnection = oldShape.outgoing.find(
         ({ target }) => isForCompensationAllowed(target)

diff --git a/test/spec/features/modeling/behavior/CompensateBoundaryEventBehaviorSpec.js b/test/spec/features/modeling/behavior/CompensateBoundaryEventBehaviorSpec.js
@@ -389,6 +389,27 @@ describe('features/modeling/behavior - compensation boundary event', function()
   ));
 
 
+  it('should NOT crash when core `replace` component is used', inject(
+    function(elementRegistry, replace) {
+
+      // given
+      const task = elementRegistry.get('Task_Compensation');
+
+      // when
+      const action = () => {
+        replace.replaceElement(task,
+          {
+            type: 'bpmn:ManualTask'
+          }
+        );
+      };
+
+      // then
+      expect(action).not.to.throw();
+    }
+  ));
+
+
   describe('copy and paste', function() {
 
     it('should NOT break on copy and paste', inject(function(canvas, copyPaste, elementRegistry) {