Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After pasting, all pasted elements should be selected #1152

Closed
1 task
nikku opened this issue Aug 8, 2019 · 2 comments
Closed
1 task

After pasting, all pasted elements should be selected #1152

nikku opened this issue Aug 8, 2019 · 2 comments
Assignees
@pinussilvestrus
Labels
bug Something isn't working
Milestone
M30

Comments

@nikku
Copy link
Member

nikku commented Aug 8, 2019

Describe the Bug

The old (< 5) behavior of the library was that all elements that got pasted are selected afterwards. This is a standard behavior seen in all sorts of applications.

The new behavior is that the first element created is being selected. As a side-effect, direct editing gets enabled when it should not:

capture dmRJ2s_optimized

Steps to Reproduce

  • Create two tasks
  • Select both
  • Copy + Paste them
  • See how only first element is selected, direct editing activates for it

Expected Behavior

  • all pasted elements are selected

Environment

  • Browser: Any
  • OS: Any
  • Library version: v5.0.0-beta.0
@nikku nikku added the bug Something isn't working label Aug 8, 2019
@nikku nikku mentioned this issue Aug 8, 2019
Closed
5 tasks
@nikku nikku added the ready Ready to be worked on label Aug 8, 2019 — with bpmn-io-tasks
@nikku nikku added this to the M30 milestone Aug 8, 2019
@pinussilvestrus pinussilvestrus self-assigned this Aug 8, 2019
@philippfromme
Copy link
Contributor

Needs fix in SelectionBehavior. 🛠

pinussilvestrus pushed a commit to bpmn-io/diagram-js that referenced this issue Aug 8, 2019
fix(selection): select all created elements
8726a13 
Closes bpmn-io/bpmn-js#1152
pinussilvestrus pushed a commit to bpmn-io/diagram-js that referenced this issue Aug 8, 2019
feat(selection-behavior): select all or specific elements after create
342b682 
Closes bpmn-io/bpmn-js#1152
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Aug 8, 2019
This was referenced Aug 8, 2019
Merged
Merged
philippfromme pushed a commit that referenced this issue Aug 9, 2019
@philippfromme
feat(palette): select start event when creating sub process
20114ae 
* use autoSelect hint to only select start event after create

Related to #1152
philippfromme pushed a commit that referenced this issue Aug 9, 2019
@philippfromme
feat(palette): select start event when creating sub process
38299ca 
* use autoSelect hint to only select start event after create

Related to #1152
philippfromme pushed a commit to bpmn-io/diagram-js that referenced this issue Aug 9, 2019
@philippfromme
feat(selection-behavior): add autoSelect hint
67a7c16 
* autoSelect === Array<djs.model.Base> selects elements
* autoSelect === false selects no elements

Related to bpmn-io/bpmn-js#1152
philippfromme pushed a commit to bpmn-io/diagram-js that referenced this issue Aug 9, 2019
@philippfromme
feat(selection-behavior): add autoSelect hint
29c0447 
* autoSelect === Array<djs.model.Base> selects elements
* autoSelect === false selects no elements

Related to bpmn-io/bpmn-js#1152
merge-me bot pushed a commit to bpmn-io/diagram-js that referenced this issue Aug 9, 2019
@merge-me
feat(selection-behavior): add autoSelect hint
46863a5 
* autoSelect === Array<djs.model.Base> selects elements
* autoSelect === false selects no elements

Related to bpmn-io/bpmn-js#1152
merge-me bot pushed a commit that referenced this issue Aug 9, 2019
@merge-me
feat(palette): select start event when creating sub process
1470d04 
* use autoSelect hint to only select start event after create

Related to #1152
@nikku
Copy link
Member Author

nikku commented Aug 9, 2019 •
edited
Loading

Closed via bpmn-io/diagram-js#392.

@nikku nikku closed this as completed Aug 9, 2019
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label Aug 9, 2019
@pinussilvestrus pinussilvestrus mentioned this issue Aug 12, 2019
Closed
@barmac barmac mentioned this issue Aug 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pinussilvestrus pinussilvestrus

Labels
bug Something isn't working
Projects
None yet
Milestone
M30
Development

No branches or pull requests
3 participants
@nikku @philippfromme @pinussilvestrus