Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working undo/redo for multi-instance #1960

Closed
shibaaboy opened this issue Sep 26, 2023 · 11 comments
Closed

Not working undo/redo for multi-instance #1960

shibaaboy opened this issue Sep 26, 2023 · 11 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest pr welcome We rely on a community contribution to improve this. spring cleaning Could be cleaned up one day

Comments

@shibaaboy
Copy link

shibaaboy commented Sep 26, 2023

Describe the Bug

When I set a Task or SubProcess as multi-instance and change the type (parallel or serial) and then use undo/redo, there is no visual change (parallel or serial is not shown).

Steps to Reproduce

Click on A Task
Mark it as multi-instance using the replace menu
Use undo/redo -> no visual change

2023-09-26.14.49.08.mov
@shibaaboy shibaaboy added the bug Something isn't working label Sep 26, 2023
@barmac
Copy link
Member

barmac commented Sep 26, 2023

I cannot reproduce it at https://demo.bpmn.io/s/start

@barmac
Copy link
Member

barmac commented Sep 26, 2023

What's your setup? Are there any errors in the developer tools?

@barmac barmac added the needs more information Requires additional information to be actionable. label Sep 26, 2023
@shibaaboy
Copy link
Author

https://demo.bpmn.io/s/start - url
if i use undo/redo - no visual change (parallel or serial)
Снимок экрана 2023-09-26 в 17 47 51
Снимок экрана 2023-09-26 в 17 48 15

Type icon doesn't change when i use undo/redo

@shibaaboy
Copy link
Author

shibaaboy commented Sep 26, 2023

  1. add a task or subprocess
  2. change type - parallel -> Task/SubProcess with icon or
  3. change type - serial -> Task/SubProcess with another icon
  4. use undo (command + z) -> no visual change ( type must be parallel )
  5. use undo (command + z) -> visual change ( without type )

when undo/redo changes in sequence types are not shown

@barmac
Copy link
Member

barmac commented Sep 26, 2023

OK I can reproduce it now. So I need to change first to parallel, then to sequence. Thanks for a clear way to reproduce it.

@barmac barmac added ready Ready to be worked on good first issue Good for newcomers spring cleaning Could be cleaned up one day and removed needs more information Requires additional information to be actionable. labels Sep 26, 2023
@shibaaboy
Copy link
Author

@barmac Will this be fixed?

@barmac barmac added pr welcome We rely on a community contribution to improve this. hacktoberfest labels Sep 26, 2023
@barmac
Copy link
Member

barmac commented Sep 26, 2023

We are happy to accept external contributions, but otherwise it's on our list.

@unix-unicorn
Copy link

Could you please assign this to me? I'm interested in taking it on. Are there any specific timelines for its completion or release?

@barmac
Copy link
Member

barmac commented Oct 2, 2023

Hi, feel free to prepare a PR. As long as there is no in progress label, we are not working on this.

@barmac barmac self-assigned this Oct 10, 2023
barmac added a commit that referenced this issue Oct 10, 2023
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Oct 10, 2023
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Oct 10, 2023
barmac added a commit that referenced this issue Oct 10, 2023
barmac added a commit that referenced this issue Oct 11, 2023
nikku pushed a commit that referenced this issue Oct 12, 2023
@nikku
Copy link
Member

nikku commented Oct 12, 2023

Closed via #1970.

@nikku nikku closed this as completed Oct 12, 2023
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 12, 2023
barmac added a commit that referenced this issue Oct 12, 2023
@shibaaboy
Copy link
Author

Thanks for the solution!

barmac added a commit that referenced this issue Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest pr welcome We rely on a community contribution to improve this. spring cleaning Could be cleaned up one day
Projects
None yet
Development

No branches or pull requests

4 participants