Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snap During Resize #1046

Merged
merged 5 commits into from
Jun 5, 2019
Merged

Snap During Resize #1046

merged 5 commits into from
Jun 5, 2019

Conversation

philippfromme
Copy link
Contributor

@philippfromme philippfromme commented May 23, 2019

  • move behaviors that are not related to snapping to their own respective behaviors
  • separate snapping into create/move and connect snapping
  • move generic snapping to diagram-js

Requires bpmn-io/diagram-js#344.
Related to camunda/camunda-modeler#1290.
Related to camunda/camunda-modeler#609.
Related to camunda/camunda-modeler#608.
Closes #562.

@philippfromme philippfromme changed the title WIP Snap During Resize Snap During Resize May 23, 2019
@philippfromme philippfromme requested a review from nikku May 23, 2019 21:07
@philippfromme philippfromme force-pushed the 1290-snap-on-resize branch 2 times, most recently from 6bbd725 to 84dbeb3 Compare May 29, 2019 13:20
@nikku nikku added the needs review Review pending label May 31, 2019 — with bpmn-io-tasks
@philippfromme philippfromme force-pushed the 1290-snap-on-resize branch 2 times, most recently from c896353 to b1a4a42 Compare June 3, 2019 08:52
@nikku nikku merged commit a98c8e3 into master Jun 5, 2019
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jun 5, 2019
@delete-merged-branch delete-merged-branch bot deleted the 1290-snap-on-resize branch June 5, 2019 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snap labels with each other
2 participants