Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(layouter): prefer straight layout for sub-process connections #1309

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

barmac
Copy link
Member

@barmac barmac commented Apr 8, 2020

Before:
image

After:
image

Related to camunda/camunda-modeler#1758

@barmac barmac requested review from a team, philippfromme and pinussilvestrus and removed request for a team April 8, 2020 09:40
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Apr 8, 2020
@nikku
Copy link
Member

nikku commented Apr 8, 2020

Me, being the author of camunda/camunda-modeler#1758, had a quick look UX wise. I think this is a major improvement 👍.

@barmac barmac requested a review from nikku April 8, 2020 11:03
@barmac
Copy link
Member Author

barmac commented Apr 8, 2020

Me, being the author of camunda/camunda-modeler#1758, had a quick look UX wise. I think this is a major improvement 👍.

I didn't want to break your slack time :) Thanks for feedback!

Copy link
Contributor

@pinussilvestrus pinussilvestrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels very good 👏

@fake-join fake-join bot merged commit f174554 into develop Apr 8, 2020
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Apr 8, 2020
@fake-join fake-join bot deleted the layout-straight-for-subprocess branch April 8, 2020 11:14
@falko
Copy link
Member

falko commented Apr 8, 2020

Thx. This is an awesome UX improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants