Round connection corners #1828
Merged
Round connection corners #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
High-level feedback: This looks awesome. Feels much easier on the eyes. I've seen quite a few people requesting/wanting to implement this in the forum. I think our users will love this. |
|
Looks good. But since this depends on bpmn-io/diagram-js#747, can we make it a draft and revert when it's ready to be reviewed officially and merged? |
|
@smbea I'd rather get bpmn-io/diagram-js#747 reviewed, and incorporated 😉 |
bpmn-io-tasks
bot
added
in progress
nikku
force-pushed
the
render-improvements
branch
from
4f205e7
to
d335fa9
Compare
nikku
changed the base branch from
render-improvements
to
refurbish-bpmn-rendering
nikku
force-pushed
the
round-corners
branch
3 times, most recently
from
5ccc15a
to
c038af6
Compare
nikku
force-pushed
the
refurbish-bpmn-rendering
branch
from
36380e3
to
4b2f3ea
Compare
bpmn-io-tasks
bot
added
needs review
nikku
force-pushed
the
refurbish-bpmn-rendering
branch
from
4b2f3ea
to
b372ca5
Compare
|
Ready for review now. |
41 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds round corner rendering for sequence and message flows. Builds on top of bpmn-io/diagram-js#747.
Simple Example
Complex Example
Compare complex to current version.
Improved join
Sub-Process Borders vs. connection corners
Depends on bpmn-io/diagram-js#747