-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: render markers as part of djs-visual #2173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this change; local markers (for coloring) seems to be a good thing to do, and it benefits the issue at hand (CSS styling), too.
Still need to E2E test this against a larger diagram. Good job 👏
I manually tested against |
32cfc2b
to
d8791a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't assume that rendering of these cryptic markers was ever done via userland CSS, hence I regard these changes as not breaking.
Good job 🌵
@marstamm Please verify the diagram-js update does not break dmn-js, and if it does bump diagram-js there, too. Please also cut a release of this change (in bpmn-js), so users can have a clean (and compatible) install again. |
I verified that the diagram-js update does not break dmn-js. I'll release bpmn-js soon, but old bpmn-js versions are also compatible with the new diagram-js version. Only reason some tests failed before the update was a CSS selector checking for a certain number of |
I want to get #1676 (comment) into the release |
Released as v17.8.0 |
This allows styling with
canvas.addMarker
and css, as described in our examples.Requires bpmn-io/diagram-js#906
related to camunda/camunda-modeler#4307