Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rules for alignment and distribution #656

Merged
merged 3 commits into from
Jul 6, 2022

Conversation

barmac
Copy link
Member

@barmac barmac commented Jul 1, 2022

No description provided.

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Jul 1, 2022
@barmac barmac force-pushed the remove-built-in-distribution-filter branch from fde57a0 to 17801ff Compare July 1, 2022 13:42
@barmac barmac force-pushed the remove-built-in-distribution-filter branch from 17801ff to 7f4f047 Compare July 5, 2022 13:56
@barmac barmac requested review from a team, pinussilvestrus and marstamm and removed request for a team July 5, 2022 14:51
@barmac barmac marked this pull request as ready for review July 5, 2022 14:51
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jul 5, 2022
@barmac
Copy link
Member Author

barmac commented Jul 5, 2022

This is now ready for review.

Copy link
Contributor

@marstamm marstamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the use of rules and getting rid of the magic "filter big elements" code

@fake-join fake-join bot merged commit 91634bd into develop Jul 6, 2022
@fake-join fake-join bot deleted the remove-built-in-distribution-filter branch July 6, 2022 07:16
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants