Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update variable name after element is renamed in each editor #863

Closed
1 of 2 tasks
barmac opened this issue May 10, 2024 · 2 comments · Fixed by #893
Closed
1 of 2 tasks

Update variable name after element is renamed in each editor #863

barmac opened this issue May 10, 2024 · 2 comments · Fixed by #893
Assignees
@abdul99ahad
Labels
bug Something isn't working good first issue Good for newcomers spring cleaning Could be cleaned up one day

Comments

@barmac
Copy link
Member

barmac commented May 10, 2024 •
edited by abdul99ahad
Loading

What should we do?

Update variable name after element is renamed in each editor.
This can be done via NameChangeBehavior, given that it is adjusted to each of the editors.

  • When an element's name changes, the name of the attached variable should update accordingly.
  • When a variable is created, it should be named as the element (at least empty string).

Why should we do it?

Variable name has to be equal to the element name if variable is present. This is part of the specification.
@barmac barmac added enhancement New feature or request backlog Queued in backlog labels May 10, 2024
@barmac
Copy link
Member Author

barmac commented Aug 6, 2024

Missing variable name causes a problem with the engine now. Reported via: https://camunda.slack.com/archives/C0693F1NFK5/p1722935552452819

@barmac barmac added bug Something isn't working ready Ready to be worked on and removed backlog Queued in backlog enhancement New feature or request labels Aug 6, 2024
@barmac
Copy link
Member Author

barmac commented Aug 6, 2024

I'd consider this to be a bug since DMN specification requires the variable name to follow the element name.

@barmac barmac added spring cleaning Could be cleaned up one day good first issue Good for newcomers labels Aug 6, 2024
@abdul99ahad abdul99ahad added the in progress Currently worked on label Aug 21, 2024 — with bpmn-io-tasks
@abdul99ahad abdul99ahad removed the ready Ready to be worked on label Aug 21, 2024
abdul99ahad added a commit that referenced this issue Aug 26, 2024
@abdul99ahad
fix: variable name changes when element name/label changes
8f77f29 
Closes #863
@abdul99ahad abdul99ahad mentioned this issue Aug 26, 2024
Merged
2 tasks
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Aug 26, 2024
abdul99ahad added a commit that referenced this issue Aug 26, 2024
@abdul99ahad
fix: variable name changes when element name/label changes
2ca70f5 
Closes #863
abdul99ahad added a commit that referenced this issue Aug 26, 2024
@abdul99ahad
fix: variable name changes when element name/label changes
0aced41 
Closes #863
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Aug 27, 2024
abdul99ahad added a commit that referenced this issue Aug 28, 2024
@abdul99ahad
fix: variable name changes when element name/label changes
bf51fc5 
Closes #863
abdul99ahad added a commit that referenced this issue Aug 30, 2024
@abdul99ahad
fix: variable name changes when element name/label changes
760ba19 
Closes #863
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Aug 30, 2024
abdul99ahad added a commit that referenced this issue Oct 3, 2024
@abdul99ahad
fix: variable name changes when element name/label changes
dac2aee 
Closes #863
abdul99ahad added a commit that referenced this issue Oct 3, 2024
@abdul99ahad
fix: variable name changes when element name/label changes
48b63ef 
Closes #863
abdul99ahad added a commit that referenced this issue Oct 3, 2024
@abdul99ahad
fix: variable name changes when element name/label changes
82eccbb 
Closes #863
abdul99ahad added a commit that referenced this issue Oct 3, 2024
@abdul99ahad @nikku
fix: variable name changes when element name/label changes (#893)
a9804d4 
* fix: variable name changes when element name/label changes

Closes #863

* test: add cases for undo/redo

Co-authored-by: Nico Rehwaldt <nico.rehwaldt@camunda.com>

* fix: variable name state updating

* chore(CHANGELOG): update

---------

Co-authored-by: Nico Rehwaldt <nico.rehwaldt@camunda.com>
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 3, 2024
@jarekdanielak jarekdanielak mentioned this issue Oct 29, 2024
Open
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abdul99ahad abdul99ahad

Labels
bug Something isn't working good first issue Good for newcomers spring cleaning Could be cleaned up one day
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: variable name changes when element name/label changes bpmn-io/dmn-js
2 participants
@barmac @abdul99ahad