Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Top-Down Modeling #492

Merged
merged 9 commits into from
Apr 16, 2020
Merged

Top-Down Modeling #492

merged 9 commits into from
Apr 16, 2020

Conversation

philippfromme
Copy link
Contributor

@philippfromme philippfromme commented Apr 1, 2020 •
edited
Loading

  • connect from new shape to source on append
  • add auto-place
  • change layout of information requirements

Requires bpmn-io/diagram-js#443

Closes #470

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Apr 1, 2020
@philippfromme philippfromme mentioned this pull request Apr 1, 2020
Closed
@philippfromme philippfromme changed the title 479 top down modeling Top-Down Modeling Apr 1, 2020
This was referenced Apr 1, 2020
Merged
Merged
@philippfromme philippfromme marked this pull request as ready for review April 1, 2020 13:50
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Apr 1, 2020
@philippfromme philippfromme force-pushed the 479-top-down-modeling branch 3 times, most recently from d232ec8 to 0bd1dc9 Compare April 2, 2020 08:36
@barmac
Copy link
Member

barmac commented Apr 16, 2020

Can you update diagram-js with this PR?

@barmac
Copy link
Member

barmac commented Apr 16, 2020

Or maybe I will just do that. Don't bother.

@philippfromme
Copy link
Contributor Author

Oh, yeah, thank you. 👍

@barmac
Copy link
Member

barmac commented Apr 16, 2020

Oh so we depend on not yet released diagram-js changes...

barmac
barmac approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@fake-join fake-join bot merged commit 8b491d0 into develop Apr 16, 2020
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Apr 16, 2020
@fake-join fake-join bot deleted the 479-top-down-modeling branch April 16, 2020 12:41
@philippfromme philippfromme mentioned this pull request Apr 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barmac barmac barmac approved these changes

@nikku nikku Awaiting requested review from nikku

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve support for top down modeling
2 participants
@philippfromme @barmac