feat: break long expression names #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpmn-io-tasks
bot
added
needs review
marstamm
requested review from
a team,
philippfromme and
barmac
and removed request for
a team
nikku
reviewed
Jan 31, 2023
| @@ -143,7 +143,7 @@ function DefaultInputHeaderCell(props, context) { | |||
|
|
|||
| { | |||
| label ? ( | |||
| <div className="input-label" title={ translate('Input Label') }> | |||
There was a problem hiding this comment.
Shall we keep the prefix Input Label here? The intention would be to still tell users what this is, but also provide full details: Input Label - SOME TEXT THAT I ENTERED AS A USER for example.
There was a problem hiding this comment.
Makes sense, I just noticed we do it for the decision Name already
There was a problem hiding this comment.
Adjusted with 6466c76
marstamm
force-pushed
the
719-long-names
branch
from
3081fd9
to
14c0827
Compare
nikku
approved these changes
Jan 31, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
titleso hover always shows complete labelNote: I used
-webkit-line-clampfor multi-line ellipsis. This is supported in all major browsers (except IE, cf. https://caniuse.com/css-line-clamp)