Add space-related rules #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barmac
force-pushed
the
barmac-patch-1
branch
from
35a4ae9
to
889444e
Compare
barmac
force-pushed
the
barmac-patch-1
branch
from
889444e
to
8b45b18
Compare
|
Needs to be a new breaking version, due to the potential impact 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the
space-infix-opsandarray-bracket-spacingrules which we enforce already in our codebase, e.g. camunda/camunda-modeler#2534 (comment)Cf. https://eslint.org/docs/rules/space-infix-ops, https://eslint.org/docs/rules/array-bracket-spacing#always