Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mocha): fine tune rules #21

Merged
merged 1 commit into from
Oct 11, 2024
Merged

fix(mocha): fine tune rules #21

merged 1 commit into from
Oct 11, 2024

Conversation

nikku
Copy link
Member

@nikku nikku commented Oct 10, 2024

Proposed Changes

This fine-tunes the existing mocha rules, as per bpmn-io/diagram-js#936 (comment).

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@nikku nikku requested review from philippfromme, a team and abdul99ahad and removed request for a team October 10, 2024 14:05
@nikku nikku merged commit d19b8fd into main Oct 11, 2024
20 checks passed
@nikku nikku deleted the mocha-tune branch October 11, 2024 06:25
@nikku
Copy link
Member Author

nikku commented Oct 11, 2024

Merging this to unblock follow-up improvements / upgrades (ref).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippfromme philippfromme Awaiting requested review from philippfromme

@abdul99ahad abdul99ahad Awaiting requested review from abdul99ahad abdul99ahad was automatically assigned from bpmn-io/modeling-dev

Assignees

@nikku nikku

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nikku