Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON Editors scroll around when we don't want them to #1101

Closed
Skaiir opened this issue Mar 20, 2024 · 1 comment · Fixed by #1103
Closed

JSON Editors scroll around when we don't want them to #1101

Skaiir opened this issue Mar 20, 2024 · 1 comment · Fixed by #1103
Assignees
@Skaiir
Labels
bug Something isn't working

Comments

@Skaiir
Copy link
Contributor

Skaiir commented Mar 20, 2024 •
edited by vsgoulart
Loading

Describe the Bug

grafik

The following editors scroll a bunch whenever data changes. Since most data changes do no affect the structure, it would be better not to change the scroll position every time as it makes it quite difficult to watch a data-point change.

Steps to Reproduce

  1. start the playground demo
  2. scroll halfway in the output data panel
  3. modify some data through the preview form
  4. the data editor jumps around

Expected Behavior

  1. the data editor would stay on the state we're currently having a look at
@Skaiir Skaiir added bug Something isn't working backlog Queued in backlog labels Mar 20, 2024
@Skaiir Skaiir self-assigned this Mar 21, 2024
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed backlog Queued in backlog labels Mar 21, 2024
@Skaiir Skaiir mentioned this issue Mar 21, 2024
Merged
Skaiir added a commit that referenced this issue Mar 25, 2024
@Skaiir
feat: do not re-instantiate JSON editors every change
cec5bbf 
Closes #1101
Skaiir added a commit that referenced this issue Mar 25, 2024
@Skaiir
chore: fix improper json editor tests
4f109f8 
Related to #1101
Skaiir added a commit that referenced this issue Mar 25, 2024
@Skaiir
chore: fix improper json editor tests
50e1e7b 
Related to #1101
Skaiir added a commit that referenced this issue Mar 25, 2024
@Skaiir
chore: handle undefined strings
85835c7 
Related to #1101
Skaiir added a commit that referenced this issue Mar 25, 2024
@Skaiir
feat: do not re-instantiate JSON editors every change
3b0576c 
Closes #1101
Skaiir added a commit that referenced this issue Mar 25, 2024
@Skaiir
chore: fix improper json editor tests
35e0748 
Related to #1101
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Mar 25, 2024
Skaiir added a commit that referenced this issue Mar 25, 2024
@Skaiir
feat: do not re-instantiate JSON editors every change
4ec2019 
Closes #1101
Skaiir added a commit that referenced this issue Mar 25, 2024
@Skaiir
chore: fix improper json editor tests
a3d220a 
Related to #1101
@Skaiir
Copy link
Contributor Author

Skaiir commented Mar 25, 2024

Closed via #1103

@Skaiir Skaiir closed this as completed Mar 25, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Mar 25, 2024
@barmac barmac mentioned this issue Apr 4, 2024
Closed
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Skaiir Skaiir

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: do not re-instantiate JSON editors on every change bpmn-io/form-js
1 participant
@Skaiir