Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It is possible to undo redo on the form output panel #1107

Closed
Skaiir opened this issue Mar 25, 2024 · 2 comments
Closed

It is possible to undo redo on the form output panel #1107

Skaiir opened this issue Mar 25, 2024 · 2 comments
Assignees
@Skaiir
Labels
bug Something isn't working spring cleaning Could be cleaned up one day

Comments

@Skaiir
Copy link
Contributor

Skaiir commented Mar 25, 2024

Describe the Bug

image

The form output panel is a non editable state representation of the form output, but it is still possible to ctrl-z/ctrl-y to undo/redo changes to it.

Steps to Reproduce

  1. run the playground
  2. edit a field
  3. press ctrl-z while in focus of the form output panel
  4. the edit to the field is reverted

Expected Behavior

  1. nothing should happen, this pane should be read-only
@Skaiir Skaiir added bug Something isn't working backlog Queued in backlog spring cleaning Could be cleaned up one day labels Mar 25, 2024
Skaiir added a commit that referenced this issue Mar 27, 2024
@Skaiir
fix: make the JSON editor readonly truly readonly
f10a3d9 
Closes #1107
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Mar 27, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the backlog Queued in backlog label Mar 27, 2024
@Skaiir Skaiir mentioned this issue Mar 27, 2024
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Mar 27, 2024
@barmac barmac mentioned this issue Mar 27, 2024
Closed
@barmac
Copy link
Member

barmac commented Mar 27, 2024

I can reproduce it in the current RC of Desktop Modeler.

Skaiir added a commit that referenced this issue Mar 27, 2024
@Skaiir
fix: make the JSON editor readonly truly readonly
8bf898a 
Closes #1107
@Skaiir
Copy link
Contributor Author

Skaiir commented Mar 28, 2024

Closed via #1110

@Skaiir Skaiir closed this as completed Mar 28, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Skaiir Skaiir

Labels
bug Something isn't working spring cleaning Could be cleaned up one day
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Skaiir @barmac