Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separator component to visually emphasize field groups #480

Closed
christian-konrad opened this issue Jan 4, 2023 · 3 comments · Fixed by #847
Closed

Separator component to visually emphasize field groups #480

christian-konrad opened this issue Jan 4, 2023 · 3 comments · Fixed by #847
Assignees
Labels
enhancement New feature or request spring cleaning Could be cleaned up one day

Comments

@christian-konrad
Copy link
Contributor

Is your feature request related to a problem? Please describe

With the new components and text view features, it can get quite difficult to visually differentiate groups of fields/components, as shown in this example.

Bildschirmfoto 2023-01-04 um 10 40 00

Describe the solution you'd like

To visually emphasize separate groups/blocks of fields/components, a separator component (a horizontal line) is a simple, but helpful tool.

Bildschirmfoto 2023-01-04 um 10 41 09

Describe alternatives you've considered

Support "---" in the text view markdown. But I advise against it, since it is hard to discover. A dedicated component is easier to find.

@christian-konrad christian-konrad added the enhancement New feature or request label Jan 4, 2023
@nikku
Copy link
Member

nikku commented Jan 4, 2023

There exist some alternatives to accomplish visual grouping:

  • Provide micro-building blocks (horizontal rule, as you suggest)
  • Stack fields (optionally) into groups and clearly separate groups from each other, visually. Also, give groups titles (seen in screen above, too)

It would be interesting which direction you want to go.

@nikku nikku added the backlog Queued in backlog label Jan 6, 2023 — with bpmn-io-tasks
@nikku nikku removed the backlog Queued in backlog label Jan 6, 2023
@Skaiir Skaiir added the backlog Queued in backlog label Jan 10, 2023
@Skaiir
Copy link
Contributor

Skaiir commented Jan 10, 2023

@RomanKostka Of interest

@Skaiir Skaiir added the spring cleaning Could be cleaned up one day label Jul 21, 2023
@volodymyr-melnykc
Copy link

volodymyr-melnykc commented Oct 16, 2023

As a part of this issue, we're introducing a horizontal separator component.
The component is named "Separator".

To help the user easily differentiate components, we're also updating the icon for the Spacer component that already exists.

Below are visual references.

separator icon
spacer icon

image

Skaiir added a commit that referenced this issue Oct 16, 2023
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Oct 16, 2023
@bpmn-io-tasks bpmn-io-tasks bot removed the backlog Queued in backlog label Oct 16, 2023
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Oct 16, 2023
Skaiir added a commit that referenced this issue Oct 17, 2023
Skaiir added a commit that referenced this issue Oct 17, 2023
Skaiir added a commit that referenced this issue Oct 17, 2023
Skaiir added a commit that referenced this issue Oct 17, 2023
Skaiir added a commit that referenced this issue Oct 17, 2023
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request spring cleaning Could be cleaned up one day
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants