Feelers integration #567
Merged
Feelers integration #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skaiir
force-pushed
the
templates-integration-bugfix
branch
from
feca604
to
1fbf6ac
Compare
bpmn-io-tasks
bot
added
needs review
Skaiir
force-pushed
the
templates-integration-bugfix
branch
from
2d5464e
to
0a9086d
Compare
github-actions
bot
temporarily deployed
to
demo-templates-integration-bug
github-actions
bot
temporarily deployed
to
demo-templates-integration-bug
packages/form-js-editor/src/features/properties-panel/entries/TextEntry.js
Outdated
Show resolved
Hide resolved
packages/form-js-viewer/src/features/expression-language/ConditionChecker.js
Show resolved
Hide resolved
Comment on lines
+87
to
+91
| <h2 id="h2">h2</h2> | ||
| <h3 id="h3">h3</h3> | ||
| <h4 id="h4">h4</h4> | ||
| <h5 id="h5">h5</h5> | ||
| <h6 id="h6">h6</h6> |
There was a problem hiding this comment.
I know the changes are really small due to the transition to showdown, but I think we should at least mention there are some changes in the resulting HTML, e.g. via note in
- the commit message
- the changelog
Just some note on that we change the markdown parser to showdown and a quick reference to the specification (if there is some). I think that would help a lot already.
There was a problem hiding this comment.
Just mentioning it as it seems our users are interested in that (https://camunda-platform.slack.com/archives/C6WGNHV2A/p1678953005263759).
There was a problem hiding this comment.
Yeah I'll try and break down the commits to make this explicit.
packages/form-js-editor/test/spec/render/components/form-fields/helper/index.js
Show resolved
Hide resolved
Skaiir
force-pushed
the
templates-integration-bugfix
branch
from
1ec2517
to
2dd0f39
Compare
pinussilvestrus
force-pushed
the
templates-integration-bugfix
branch
from
2dd0f39
to
75acf11
Compare
Related to `team-hto/141`.
Related to 'team-hto/141'
Related to 'team-hto/141'
pinussilvestrus
force-pushed
the
templates-integration-bugfix
branch
from
134f45e
to
d895bac
Compare
github-actions
bot
temporarily deployed
to
demo-templates-integration-bug
| import { FeelTextAreaEntry, isFeelEntryEdited } from '@bpmn-io/properties-panel'; | ||
| import { FeelTemplatingEntry, isFeelEntryEdited } from '@bpmn-io/properties-panel'; | ||
|
|
||
| // import { simpleBoolEntryFactory } from './factories'; |
There was a problem hiding this comment.
Let's leave this in to make sure we know later where to tackle this.
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/camunda/team-hto/issues/141