Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed type definition for findIndex #37

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

abdul99ahad
Copy link
Contributor

@abdul99ahad abdul99ahad commented Aug 6, 2024

Fix type definition for findIndex

Closes issue #36

Copy link
Contributor

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a Closes #xxx to the commit message body so the issue is referenced? 🙂

@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Aug 6, 2024
@abdul99ahad abdul99ahad changed the title fix: fixed type definition for findIndex fix: fixed type definition for findIndex Aug 6, 2024
@abdul99ahad abdul99ahad changed the title fix: fixed type definition for findIndex fix: fixed type definition for findIndex #Closes #36 Aug 6, 2024
@abdul99ahad abdul99ahad changed the title fix: fixed type definition for findIndex #Closes #36 fix: fixed type definition for findIndex Closes #36 Aug 6, 2024
@abdul99ahad abdul99ahad changed the title fix: fixed type definition for findIndex Closes #36 fix: fixed type definition for findIndex Aug 6, 2024
@philippfromme philippfromme self-requested a review August 6, 2024 14:21
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Aug 6, 2024
Copy link
Contributor

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 🎉

@philippfromme philippfromme merged commit e0ef753 into main Aug 12, 2024
6 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 12, 2024
@philippfromme philippfromme deleted the 36-corrected-type-definition branch August 12, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants