chore(Group): namespace error class

bpmn-io · Jul 17, 2023 · 33d4fb4 · 33d4fb4
1 parent 1332bb7
commit 33d4fb4
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 11 deletions.
diff --git a/assets/properties-panel.css b/assets/properties-panel.css
@@ -356,7 +356,7 @@
   background-color: var(--dot-color);
 }
 
-.bio-properties-panel-dot.error {
+.bio-properties-panel-dot--error {
   background-color: var(--dot-color-error);
 }
 
@@ -387,7 +387,7 @@
   background-color: var(--list-badge-background-color);
 }
 
-.bio-properties-panel-list-badge.error {
+.bio-properties-panel-list-badge--error {
   background-color: var(--dot-color-error);
 }
 

diff --git a/src/components/Group.js b/src/components/Group.js
@@ -93,8 +93,7 @@ export default function Group(props) {
       'bio-properties-panel-group-header',
       edited ? '' : 'empty',
       open ? 'open' : '',
-      (sticky && open) ? 'sticky' : '',
-      hasErrors ? 'error' : ''
+      (sticky && open) ? 'sticky' : ''
     ) } onClick={ toggleOpen }>
       <div title={ label } class="bio-properties-panel-group-header-title">
         { label }
@@ -147,7 +146,7 @@ function DataMarker(props) {
 
   if (hasErrors) {
     return (
-      <div title="Section contains an error" class="bio-properties-panel-dot error"></div>
+      <div title="Section contains an error" class="bio-properties-panel-dot bio-properties-panel-dot--error"></div>
     );
   }
 

diff --git a/src/components/ListGroup.js b/src/components/ListGroup.js
@@ -192,8 +192,7 @@ export default function ListGroup(props) {
         'bio-properties-panel-group-header',
         hasItems ? '' : 'empty',
         (hasItems && open) ? 'open' : '',
-        (sticky && open) ? 'sticky' : '',
-        hasError ? 'error' : ''
+        (sticky && open) ? 'sticky' : ''
       ) }
       onClick={ hasItems ? toggleOpen : noop }>
       <div
@@ -230,7 +229,7 @@ export default function ListGroup(props) {
                 class={
                   classnames(
                     'bio-properties-panel-list-badge',
-                    hasError ? 'error' : ''
+                    hasError ? 'bio-properties-panel-list-badge--error' : ''
                   )
                 }
               >

diff --git a/test/spec/components/Group.spec.js b/test/spec/components/Group.spec.js
@@ -233,7 +233,7 @@ describe('<Group>', function() {
 
       const header = domQuery('.bio-properties-panel-group-header', result.container);
 
-      const errorMarker = domQuery('.bio-properties-panel-dot.error', header);
+      const errorMarker = domQuery('.bio-properties-panel-dot--error', header);
 
       // then
       expect(errorMarker).to.exist;

diff --git a/test/spec/components/ListGroup.spec.js b/test/spec/components/ListGroup.spec.js
@@ -100,7 +100,7 @@ describe('<ListGroup>', function() {
 
       const { container } = createListGroup({ container: parentContainer, items, errors });
 
-      const errorBadge = domQuery('.bio-properties-panel-list-badge.error', container);
+      const errorBadge = domQuery('.bio-properties-panel-list-badge--error', container);
 
       // then
       expect(errorBadge).to.exist;
@@ -133,7 +133,7 @@ describe('<ListGroup>', function() {
 
       const { container } = createListGroup({ container: parentContainer, items, errors });
 
-      const errorBadge = domQuery('.bio-properties-panel-list-badge.error', container);
+      const errorBadge = domQuery('.bio-properties-panel-list-badge--error', container);
 
       // then
       expect(errorBadge).to.exist;