Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: element tab tooltip cutoff #3

Closed
wants to merge 1 commit into from
Closed

Conversation

abdul99ahad
Copy link

@abdul99ahad abdul99ahad commented Sep 8, 2024

Proposed Changes

Fixed Element tab tooltip cutting off
Sep-09-2024 00-55-23

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

Related to: camunda/camunda-modeler#4496

@philippfromme
Copy link

The fix I had in mind wouldn't try to fit the tooltips inside a specific container but would put them on top of everything just like the properties panel tooltips.

brave_ZbRMvD0ZiN

Copy link

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regardless of how we fix the issue we need to make sure we fix it for all tooltips.

@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review required labels Sep 9, 2024
@nikku
Copy link
Member

nikku commented Sep 9, 2024

@abdul99ahad from my investigations the issue is a miss-use of overflow, cf. capture below:

capture AyetlV_optimized

Overflow and popup container absolute positioning simply conflict, cf. https://stackoverflow.com/questions/3550795/is-it-possible-to-have-a-popup-div-that-breaks-out-of-an-overflowscroll-or-ov (and many other references on the web).

@abdul99ahad
Copy link
Author

@abdul99ahad from my investigations the issue is a miss-use of overflow, cf. capture below:

capture AyetlV_optimized capture AyetlV_optimized

Yes @nikku, you’re right. The overflow property is preventing the tooltip from hovering over other elements. I’ve spent a lot of time trying different solutions, but the only one that seems to work is removing the overflow property, which isn’t feasible. As a result, I had to restrict the tooltip to stay within the container.

@nikku
Copy link
Member

nikku commented Sep 18, 2024

Did some more research and found the upstream bug report: carbon-design-system/carbon#14677.

I propose we solve this either by implementing a proper (global, position: fixed) tooltip (we don't use Carbon UI for the time being) or not at all. To me it does not feel right to workaround with a what looks like "local" CSS fix.

As you proposed this PR, could you evaluate @abdul99ahad: Is this something that is robust enough, and also works for other tooltips that we may introduce, or is this just a quick workaround? If it is the later, then I'd rather not merge this (today) but consider another direction.

@nikku
Copy link
Member

nikku commented Sep 18, 2024

As discussed we'll close this PR in favor of a controlled update of our tooltip infrastructure, some day maybe.

If we fix the tips, we want to fix them alltogether.

@nikku nikku closed this Sep 18, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants