-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: element tab tooltip cutoff #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regardless of how we fix the issue we need to make sure we fix it for all tooltips.
@abdul99ahad from my investigations the issue is a Overflow and popup container absolute positioning simply conflict, cf. https://stackoverflow.com/questions/3550795/is-it-possible-to-have-a-popup-div-that-breaks-out-of-an-overflowscroll-or-ov (and many other references on the web). |
Yes @nikku, you’re right. The overflow property is preventing the tooltip from hovering over other elements. I’ve spent a lot of time trying different solutions, but the only one that seems to work is removing the overflow property, which isn’t feasible. As a result, I had to restrict the tooltip to stay within the container. |
Did some more research and found the upstream bug report: carbon-design-system/carbon#14677. I propose we solve this either by implementing a proper (global, As you proposed this PR, could you evaluate @abdul99ahad: Is this something that is robust enough, and also works for other tooltips that we may introduce, or is this just a quick workaround? If it is the later, then I'd rather not merge this (today) but consider another direction. |
As discussed we'll close this PR in favor of a controlled update of our tooltip infrastructure, some day maybe. If we fix the tips, we want to fix them alltogether. |
Proposed Changes
Fixed Element tab tooltip cutting off
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/sr
toolCloses {LINK_TO_ISSUE}
orRelated to {LINK_TO_ISSUE}
Related to: camunda/camunda-modeler#4496