Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: use holding objects instead of passing EtlState by reference #13

Merged
merged 5 commits into from
Nov 6, 2023

Conversation

bpolaszek
Copy link
Owner

No description provided.

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (edb0366) 100.00% compared to head (4c72202) 100.00%.

❗ Current head 4c72202 differs from pull request most recent head e02530a. Consider uploading reports for the commit e02530a to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##              master       #13   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       193       196    +3     
===========================================
  Files             41        42    +1     
  Lines            490       512   +22     
===========================================
+ Hits             490       512   +22     
Files Coverage Δ
src/EtlExecutor.php 100.00% <100.00%> (ø)
src/Internal/Ref.php 100.00% <100.00%> (ø)
src/functions.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bpolaszek bpolaszek marked this pull request as ready for review November 6, 2023 13:55
@bpolaszek bpolaszek merged commit 2e5f893 into master Nov 6, 2023
2 checks passed
@bpolaszek bpolaszek deleted the refactor/refs branch November 6, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant