[CLOSED] Disabled remote-debugging by default and appshell.app.getRemoteDebuggingPort() needs a callback argument to work

[core-ai-bot]

Issue by jha-g
Wednesday Nov 06, 2019 at 13:38 GMT
Originally opened as adobe#668

---

• Disabling remote debugging by default, and it can be enabled by passing a command line arg as --remote-debugging-port=xxxx
• Changed appshell.app.getRemoteDebuggingPort() implementation to require a callback
• Added validation for port range, and also without remote-debugging-port we will not be able to debug brackets using a browser, and if browser debugging is disabled, appshell.app.getRemoteDebuggingPort(callback) will print 0

---

jha-g included the following code: https://github.com/adobe/brackets-shell/pull/668/commits

[core-ai-bot]

Comment by jha-g
Monday Nov 11, 2019 at 06:16 GMT

---

Addressed all the review comments.

[core-ai-bot]

Comment by swmitra
Monday Nov 11, 2019 at 09:36 GMT

---

@vickramdhawal Can you please take a quick look?

[core-ai-bot]

Comment by jha-g
Monday Nov 11, 2019 at 17:33 GMT

---

@vickramdhawal Addressed review comments. It is not possible to use g_handler to hold remote-debugging-port as g_handler does not get initialized while we are parsing command line.