[CLOSED] Add cut/copy/paste to the context menu

[core-ai-bot]

Issue by ficristo
Sunday Aug 14, 2016 at 15:06 GMT
Originally opened as adobe/brackets#12674

---

Switch cut/copy/paste to use document.execCommand and add them to the context menu.
Before, on right click the underline word were selected but it was counterintuitive for the context menu usage so I removed it.
We need adobe/brackets-shell#567 to make the paste command work.

---

ficristo included the following code: https://github.com/adobe/brackets/pull/12674/commits

[core-ai-bot]

Comment by MarcelGerber
Sunday Aug 14, 2016 at 15:19 GMT

---

First things first: We don't need the ignoreCommand handler any more :)

What's the behaviour on Linux, as execCommand("copy/cat/paste") is only supported in Chrome 42+?

[core-ai-bot]

Comment by ficristo
Sunday Aug 14, 2016 at 16:59 GMT

---

Oddly seemed to work for me on Ubuntu 16.04 without any other changes.
Would be nice to have some confirmations.
(I didn't try the installer and I don't know if would change anything)

[core-ai-bot]

Comment by MarcelGerber
Sunday Aug 14, 2016 at 17:29 GMT

---

Yeah, confirmed on Linux now. Works without any shell changes.
Works fine on Windows for me, too.

I just noticed one issue:

1. Position your cursor on the end of a line that consists of only spaces for indentation.
2. Right-click anywhere in that line

Result: The whitespace is selected, which makes pasting a whole lot harder, as it will delete the whitespace.

[core-ai-bot]

Comment by ficristo
Sunday Aug 14, 2016 at 17:51 GMT

---

The whitespace is selected

I cannot reproduce...

[core-ai-bot]

Comment by MarcelGerber
Sunday Aug 14, 2016 at 18:10 GMT

---

Strange. I can't reproduce any more either.

[core-ai-bot]

Comment by zaggino
Thursday Aug 25, 2016 at 22:31 GMT

---

Tested. "Cut" and "Copy" work fine, "Paste" doesn't do anything for me. Windows shell.

[core-ai-bot]

Comment by ficristo
Friday Aug 26, 2016 at 05:24 GMT

---

"Paste" doesn't do

Have you tested with the shell PR? Otherwise is expected.

[core-ai-bot]

Comment by zaggino
Friday Aug 26, 2016 at 05:28 GMT

---

Ah, my bad. Gonna test and merge if it works.

[core-ai-bot]

Comment by ficristo
Friday Aug 26, 2016 at 05:31 GMT

---

Can you wait to merge? I need to cleanup a bit this first.

[core-ai-bot]

Comment by zaggino
Friday Aug 26, 2016 at 05:34 GMT

---

👍 ping me then

[core-ai-bot]

Comment by MarcelGerber
Thursday Sep 01, 2016 at 13:58 GMT

---

@ficristo Would love to merge this after your cleanup work is done!

[core-ai-bot]

Comment by ficristo
Thursday Sep 01, 2016 at 19:46 GMT

---

I've removed the unused ignoreCommand.
Now it's ready for another pass.

[core-ai-bot]

Comment by MarcelGerber
Thursday Sep 01, 2016 at 20:16 GMT

---

All good.
Thank you!

[core-ai-bot]

Comment by GuyRogers
Thursday Nov 10, 2016 at 12:27 GMT

---

Thanks so much for the Cut/Copy/Paste. It was one of the few things that was driving me mad in Brackets 👍