-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Add cut/copy/paste to the context menu #12674
Conversation
First things first: We don't need the What's the behaviour on Linux, as |
Oddly seemed to work for me on Ubuntu 16.04 without any other changes. |
Yeah, confirmed on Linux now. Works without any shell changes. I just noticed one issue:
Result: The whitespace is selected, which makes pasting a whole lot harder, as it will delete the whitespace. |
I cannot reproduce... |
Strange. I can't reproduce any more either. |
Tested. "Cut" and "Copy" work fine, "Paste" doesn't do anything for me. Windows shell. |
Have you tested with the shell PR? Otherwise is expected. |
Ah, my bad. Gonna test and merge if it works. |
Can you wait to merge? I need to cleanup a bit this first. |
👍 ping me then |
@ficristo Would love to merge this after your cleanup work is done! |
62505c5
to
d93ccc5
Compare
I've removed the unused ignoreCommand. |
All good. |
Thanks so much for the Cut/Copy/Paste. It was one of the few things that was driving me mad in Brackets 👍 |
relies on document.execCommand() which doesn't work well (esp. for paste) in browsers. See adobe#12674. This reverts commit d93ccc5.
Switch cut/copy/paste to use
document.execCommand
and add them to the context menu.Before, on right click the underline word were selected but it was counterintuitive for the context menu usage so I removed it.
We need adobe/brackets-shell#567 to make the paste command work.