[CLOSED] Improvements to middle-click closing files

[core-ai-bot]

Issue by peterflynn
Thursday Jul 25, 2013 at 21:07 GMT
Originally opened as adobe/brackets#4576

---

Improved fix for #3889 (Middle click should close files)

• Don't go through normal selection-click handling codepath first: detect middle click in the same place we filter out close-button clicks. This means the file is closed instantly, as opposed to a delay while it's loaded / switched to first. No longer need a separate middle-click listener as a result.
• Use constants for event.which
• Remove long-commented-out rename code
• Move misplaced comment ("might never have been opened") to its rightful home

@RaymondLim I think this conflicts a little bit with your advice in the original PR #3901, so maybe you could take a look?

---

peterflynn included the following code: https://github.com/adobe/brackets/pull/4576/commits

[core-ai-bot]

Comment by RaymondLim
Wednesday Jul 31, 2013 at 23:50 GMT

---

Looks good. Merging.

[core-ai-bot]

Comment by peterflynn
Wednesday Jul 31, 2013 at 23:56 GMT

---

Thanks for the review@RaymondLim!