This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Improvements to middle-click closing files #4576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't go through normal selection-click handling codepath first: detect
middle click in the same place we filter out close-button clicks. No longer
need a separate click listener as a result.
- Use constants for event.which
- Remove long-commented-out rename code
- Move misplaced comment ("might never have been opened") to its rightful
home
ghost
assigned 
| @@ -42,6 +42,10 @@ define(function (require, exports, module) { | |||
| ViewUtils = require("utils/ViewUtils"); | |||
|
|
|||
|
|
|||
| /** @const @type {number} Constants for event.which values */ | |||
| var LEFT_BUTTON = 1, | |||
| MIDDLE_BUTTON = 2; | |||
There was a problem hiding this comment.
Nice to see those defined as constant. Don't we also need to define RIGHT_BUTTON?
There was a problem hiding this comment.
Don't bother to define right button. We're not using it anywhere any way. We can always add it here when we need it.
|
Looks good. Merging. |
RaymondLim
added a commit
that referenced
this pull request
Jul 31, 2013
Improvements to middle-click closing files
|
Thanks for the review @RaymondLim! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved fix for #3889 (Middle click should close files)
@RaymondLim I think this conflicts a little bit with your advice in the original PR #3901, so maybe you could take a look?