-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLOSED] "Restart in Safe Mode" #4678
Comments
Comment by bchintx I like the idea, but could we pick a different name for this feature? Restarting in "Safe Mode" implies something completely different to a Windows user (ie. rebooting Windows into a new session with limited device drivers, startup services, etc), and this menu item might lead to confusion when a user first it. |
Comment by njx Sure, we could be more specific ("Restart Without Extensions") -- I thought "Safe Mode" was a reasonable analogy, but it's probably not exactly the same since we would reopen the same project, keep all their prefs, etc. |
Comment by bchintx "Restart Without Extensions" makes a lot of sense. Thanks! |
Comment by peterflynn What do Chrome and/or Firefox call their equivalent modes (no plugins, no extensions)? Following their naming lead might make sense to web developers... |
Comment by lkcampbell Firefox calls it Safe Mode. Chrome doesn't have this mode but the "tips and tricks" pages that simulate the action allude to Firefox's Safe Mode moniker as well. Either sounds fine to me but I think "Restart Without Extensions" is more precise. |
Comment by lkcampbell
|
Comment by redmunds My concern is how does Brackets indicate that it is running in this "mode"? A user could leave brackets open for long enough to forget that they're in this mode. Can an Extension be installed, updated, or removed in this mode? Seems like this should be disallowed, and Extension Manager should indicate this somehow. Are any other features affected? Does shutdown/restart get Brackets out of this mode? If not, then how? |
Comment by lkcampbell
Yes, I would expect shutdown/restart to be the only way to get out of the mode. |
Comment by lkcampbell Minor point, but since I am reusing the Reload Brackets functionality to create this new functionality, should we call it Reload Without Extensions? The main window never actually closes and restarts. |
Comment by redmunds
That's a good start. But have you ever stared at a disabled menu item and have no idea why it's disabled? Yeah, me too.
Sounds good. Might even want to say "Reload Without User Extensions" since default extensions should still be loaded. |
Comment by lkcampbell I can remove the menu item instead of disabling it. The thing is, though, the common scenario for using this tool has a pretty short lifespan. I typically discover a bug, move all of my extensions to the disabled folder, try to reproduce the bug, post the bug report, then move all of my extensions right back again. I spend very little time in Brackets without my extensions if I can help it. Actually, my bigger current problem is the menu items that are added by the extensions are sticking around on the reload. I'm going to look into how to revert back to a default menu setting tomorrow. |
Comment by redmunds
That doesn't solve the issue for me -- instead I'd be staring at the menu wondering where my favorite command went :) Disabling it is OK. |
Comment by lkcampbell Issue #5210 makes extension menu clean up more difficult. It needs to be addressed before this functionality can be finished. |
Comment by lkcampbell Assigning to myself since I am working on a fix. |
Comment by peterflynn
As a side effect, that should also mean we wouldn't need to use |
Comment by peterflynn CC |
Comment by lkcampbell
My solution is to remove the entire menu bar just before reloading the Brackets window in "Without User Extensions" mode, essentially a clean slate menu bar. Then, on reload, the default menu code and the default extension code repopulates the menu bar again, effectively filtering out all user extension menu changes. |
Comment by JeffryBooher
|
Comment by lkcampbell
|
Comment by lkcampbell Update: after discussing the latest PR with
When these three issues are addressed, I will submit a new, clean PR for this feature. |
Comment by lkcampbell Update:
When these three issues are addressed, I will submit a new, clean PR for this feature. |
Comment by redmunds FBNC back to |
Comment by njx Very cool - seems to work as expected. Thanks for sticking with this |
Issue by njx
Thursday Sep 05, 2013 at 20:53 GMT
Originally opened as adobe/brackets#5078
I was thinking that it might be easy to add a menu item, "Debug > Restart in Safe Mode", that would reload Brackets with a URL parameter that tells Brackets not to load any non-default extensions. Might be useful for people who are having issues with Brackets to quickly determine whether it's really a Brackets issue or an extension issue, and it's easier than having them temporarily delete or move aside individual extensions. (Of course, once they've figured out that it is an extension issue, they'd still have to narrow it down, but it would be a quick way to know that the priority isn't as high for us to track it down.)
The text was updated successfully, but these errors were encountered: