This repository has been archived by the owner on Oct 10, 2019. It is now read-only.
Feature/react transform hmre #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "no-underscore-dangle": 0, | ||
| "quotes": [2, "single"], | ||
| "semi": [2, "always"], | ||
| "space-before-function-paren": 0 |
There was a problem hiding this comment.
Not a fan of spaces between function and the opening paren, so would prefer "never" here.
|
Oliver 👍 Looks great, dropped a few comments for things that need attention. Once that's fixed up, I'd be happy to merge this. Otherwise, wonderful. Thanks so much! |
| @@ -0,0 +1 @@ | |||
| v5 | |||
There was a problem hiding this comment.
Don't think this should be committed, probably should be ignored in your local .gitignore.
| describe('Application', function() { | ||
| it('displays the component', function() { | ||
| describe('Application', function () { | ||
| it('displays the component', function () { |
There was a problem hiding this comment.
Can you please remove these leading spaces before each function so that eslint passes? There are a few more throughout the PR too.
There was a problem hiding this comment.
Sorry about that... fixed now through the awesome power of npm run lint:js -- --fix :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #24
Upgraded all deps to bleeding edge, moved from
react-hot-loaderto Babel 6 plusreact-hmrepreset, added a small example of a stateless function