Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite integration tests as a Go test #38

Merged
merged 15 commits into from
Jul 10, 2019
Merged

Conversation

bradleyjkemp
Copy link
Owner

This now means integration tests count towards code coverage 🙂

Using the CodeCov "flags" feature to be able to separately track unit and integration test coverage.

)

func TestIntegration(t *testing.T) {
go func() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SA2002: the goroutine calls T.Fatal, which must be called in the same goroutine as the test (from staticcheck)

}()

dumpLog := &bytes.Buffer{}
go func() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SA2002: the goroutine calls T.Fatal, which must be called in the same goroutine as the test (from staticcheck)

@codecov
Copy link

codecov bot commented Jul 10, 2019

Codecov Report

Merging #38 into master will increase coverage by 41.76%.
The diff coverage is 56.19%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #38       +/-   ##
===========================================
+ Coverage   16.32%   58.09%   +41.76%     
===========================================
  Files           6       30       +24     
  Lines         294     1069      +775     
===========================================
+ Hits           48      621      +573     
- Misses        240      364      +124     
- Partials        6       84       +78
Flag Coverage Δ
#integration 57.43% <56.19%> (?)
#unit 15.84% <0%> (?)
Impacted Files Coverage Δ
grpc-fixture/fixture/load.go 81.81% <ø> (ø)
grpc-dump/dump/recorded_server_stream.go 100% <ø> (ø)
grpc-fixture/fixture/fixture_interceptor.go 74.19% <ø> (ø)
grpc-proxy/config.go 46.42% <100%> (+46.42%) ⬆️
internal/connPool.go 88.88% <100%> (ø)
grpc-dump/dump/dump_interceptor.go 78.26% <100%> (ø)
internal/proxydialer/util.go 28.57% <28.57%> (ø)
grpc-proxy/proxy.go 67.85% <33.33%> (+67.85%) ⬆️
grpc-fixture/fixture/fixture.go 50% <50%> (ø)
internal/proxydialer/proxy.go 53.12% <53.12%> (ø)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1c314b...260f732. Read the comment docs.

Repository owner deleted a comment from codecov bot Jul 10, 2019
@bradleyjkemp bradleyjkemp merged commit b291f08 into master Jul 10, 2019
@bradleyjkemp bradleyjkemp deleted the go-integration-tests branch July 17, 2019 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants