-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite integration tests as a Go test #38
Conversation
) | ||
|
||
func TestIntegration(t *testing.T) { | ||
go func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SA2002: the goroutine calls T.Fatal, which must be called in the same goroutine as the test (from staticcheck
)
}() | ||
|
||
dumpLog := &bytes.Buffer{} | ||
go func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SA2002: the goroutine calls T.Fatal, which must be called in the same goroutine as the test (from staticcheck
)
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
===========================================
+ Coverage 16.32% 58.09% +41.76%
===========================================
Files 6 30 +24
Lines 294 1069 +775
===========================================
+ Hits 48 621 +573
- Misses 240 364 +124
- Partials 6 84 +78
Continue to review full report at Codecov.
|
15dbf51
to
260f732
Compare
This now means integration tests count towards code coverage 🙂
Using the CodeCov "flags" feature to be able to separately track unit and integration test coverage.