Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors not being proxied to client #45

Merged
merged 2 commits into from
Jul 29, 2019
Merged

Fix errors not being proxied to client #45

merged 2 commits into from
Jul 29, 2019

Conversation

bradleyjkemp
Copy link
Owner

Fixes the error reported in #43 (comment) where errors returned by the server were not proxied to the client.

Root cause: err variable was being overwritten by the message decoder

@bradleyjkemp bradleyjkemp added bug Something isn't working grpc-dump labels Jul 29, 2019
Repository owner deleted a comment from codecov bot Jul 29, 2019
@bradleyjkemp bradleyjkemp merged commit a0a8a9e into master Jul 29, 2019
@bradleyjkemp bradleyjkemp deleted the missing-error-return branch July 29, 2019 17:21
@bradleyjkemp bradleyjkemp mentioned this pull request Jul 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working grpc-dump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bradleyjkemp