Steven #219
Open
Steven #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code smell #1 for me is fixed.
Removed unused Import
The "return" is not needed.
…pendent statement
Removed unnecessary return statement
Product carousel - Extract this nested ternary operation into an inde…
…dependent statement
OrderScreen.js - Extract nested ternary operation to if-statements
HomeScreen.js - Extract this nested ternary operation into if statements
working on ordrescreen.js smells
Rating.js - Extract all nested ternary operations into Stars class
made the key variable unique to the item instead of the list index. This is because list indexes change and would make the key variable unsafe.
I made the html "key" variable unique to the item instead of the list index that we are looping through. This is because list index could change. Instead, we used the "item.name" since each item has a unique "name" to identify it.
This code smell was changed for better readability. What is happening is if text is truthful (meaning it is not null, undefined, 0, etc) then we render what the text prop actually is. Using the ternary operator we are able to read it much better as "If text is true and not null, then render text, otherwise, render nothing."
Using the latter "\d" is is not only shorter in terms of expression length, but also easier to read and thus to maintain. I replaced the bulky "[0-9]" with a more concise equivalent "\d"
This reverts commit ae0ef32.
This reverts commit d05b234.
…created/modified files. Removed unused imports across all created/modified files. Renamed \“contactReducer.js\” to \“contactReducers.js\” to match the established format of the names of the reducer files in the code base. (The reducer file names are all plural)
Changes look good. Tested on my machine and it works!
started implementing social login with auth0
Can move an item from the "saved for later" list to the "cart"
Fixed a bug where when the user logs out and logs back in with a DIFFERENT account, the same items in the "save for later" list were still there. Added to the userActions.js file to remove the later items list from the user's local storage when they log out.
Looks good to me after the last fix
… environment As mentioned in the email to the Professor and TA, on 4/28/2023 I coded about 35% of feature 2 on Brian's apre linux laptop on my branch thinking I was signed into my git account. This is because my Windows computer is currently broken with WSL (path variables are destroyed and deleting/re-installing is not working). So Brian let me used his spare linux laptop and later that night we realized after he went home that it pushed under his account. Fast foward to today, this morning I tried getting my commits in properly by copy/pasting the commits done in his account on the Windows computer, but this proved rather difficult as again, the project can't run on there. I made those commits around 3pm. That's when I decided to go to Best Buy to buy a MacBook with intents to return it after. This leads to this specific commit. After purchasing the MacBook, re-buying Brad's Umedy course videos to re-learn how to set up from scratch, and getting a lot of help from my team mates this time as all of them have Macs and knew how to troubleshoot compared to when I was using my Windows computer, I was finally able to re set up the project just now. In this commit, I made comments explaining the 35% of feature 2 I coded on 4/28/2023 just so the GitHub can show my name and a proper git commit with working code. Thank you in particular for your understanding and for Brian helping me the most when it came to setting up the mac book.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the trinary operator in product file and reduced comments to improve cognitive complexity