New: Add no-var-requires #114
Conversation
docs/rules/no-var-requires.md
Outdated
| Examples of **incorrect** code for this rule: | ||
|
|
||
| ```ts | ||
| require("foo"); |
There was a problem hiding this comment.
This should be allowed IMO since there isn’t an equivalent with the import = syntax.
There was a problem hiding this comment.
Yeah, I could see how introducing this as-is would be a breaking change, since all standalone require() calls would be flagged by this rule.
I will push up a fix that allows this. If we ultimately want to disallow it before merging, I will just revert the commit. 👍
tests/lib/rules/no-var-requires.js
Outdated
| ] | ||
| }, | ||
| { | ||
| code: "require('foo')", |
There was a problem hiding this comment.
I believe an unassigned call to require() is invalid, but I'm not 100% sure about this based on TSLint's no-var-requires tests. Just calling this out in case anyone has more experience with TSLint's no-var-requires rule and if this truly an invalid case.
There was a problem hiding this comment.
Users can replace require("foo"); with import "foo";. Hence an error on this require call is expected.
There was a problem hiding this comment.
Forgot about that, thanks for pointing that out. I’ll push up a commit next week when I get access to a computer
|
|
||
| ## When Not To Use It | ||
|
|
||
| If you don't care about TypeScript module syntax, then you will not need this rule. |
There was a problem hiding this comment.
These make me giggle each time.
There was a problem hiding this comment.
Haha yeah, I agree 😂
|
Thanks, @macklinu! |
This PR adds the
no-var-requiresrule as listed in the description of #5.