Skip to content
This repository has been archived by the owner on Jan 19, 2019. It is now read-only.

Fix false positives in no-triple-slash-reference #226

Merged
merged 1 commit into from
Dec 14, 2018

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Dec 13, 2018

Disallow /// <reference path="" /> comments

but it's triggered on:

  • /// <reference types="foo" />
  • /// <reference lib="es2017.string" />
  • /// <reference no-default-lib="true"/>

types/lib/no-default-lib can't be replaced by es6 imports

Copy link
Owner

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bradzacher bradzacher merged commit 2df5460 into bradzacher:master Dec 14, 2018
@armano2 armano2 deleted the no-triple-slash-reference branch December 14, 2018 17:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants