New: Add rule member-ordering #23
Conversation
|
@dannyfritz one more =), could you please update #5 |
|
Sorry again @weirdpattern for the delay, as with your other PR, would you be available to update this to include all the latest changes? |
|
@weirdpattern Not at all trying to steal your thunder but just so you know if your no longer interested I am happy to take these over :) |
|
@corbinu, no worries, I can do this, just need 1 or 2 nights to catch up, most of the code is already there, I just need to validate |
|
glad to hear it! |
|
@JamesHenry and @corbinu is it OK with you if we wait until the other PR has been approved and merged to update and rebase this PR? |
|
@weirdpattern I have merged the other PR, thanks a lot |
|
@JamesHenry alright, I'm gonna work on this tonight. |
Update documentation, include compatibility to TSLint
weirdpattern
force-pushed
the
member-ordering
branch
from
4b22dbc
to
f270fdf
Compare
|
@JamesHenry I finally found the time to do this... sorry it took me this long, was real busy at work and home... feel free to review the code and then merge it... |
|
@weirdpattern No worries we all get busy. Thanks |
docs/rules/member-ordering.md
Outdated
| - `public-instance-field` | ||
| - `protected-instance-field` | ||
| - `private-instance-field` | ||
| - `public-field` (disregard of the scope) |
There was a problem hiding this comment.
Could you clarify what disregard of means here?
There was a problem hiding this comment.
means no matter if the method is an instance method or a static method
There was a problem hiding this comment.
I updated the documentation, not really sure if this will really help...
Do let me know if anyone has a better suggestion...
|
LGTM |
|
I don't want to slow down this awesome momentum so I am going to go ahead and merge this without the most detailed of reviews 😄 Thanks so much for your efforts @weirdpattern! Even though the plugin has been around for a while, it is still early days, so I would rather just get this in and we can work on problems, if they arise. |
|
@JamesHenry makes perfect sense... |
|
I just published version 0.4.0 to npm and this PR is included in it 👍 |
This includes
New rule member-ordering
Corresponding test
Corresponding documentation
Update to README.md to include the new rule