Skip to content
This repository has been archived by the owner on Jan 19, 2019. It is now read-only.

[FEAT] [no-this-alias] Add rule #232

Merged
merged 12 commits into from
Dec 17, 2018
Merged

[FEAT] [no-this-alias] Add rule #232

merged 12 commits into from
Dec 17, 2018

Conversation

j-f1
Copy link
Collaborator

@j-f1 j-f1 commented Dec 16, 2018

No description provided.

@armano2
Copy link
Contributor

armano2 commented Dec 16, 2018

@j-f1 you have to update yarn.lock you are using eslint-docs@0.2.6 instead of eslint-docs@0.2.3

@j-f1
Copy link
Collaborator Author

j-f1 commented Dec 16, 2018

Done @armano2.

@bradzacher bradzacher changed the title Add no-this-alias rule [FEAT] [no-this-alias] Add rule Dec 16, 2018
bradzacher
bradzacher suggested changes Dec 16, 2018
View reviewed changes
Copy link
Owner

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the one change, everything else LGTM

lib/rules/no-this-alias.js Outdated Show resolved Hide resolved
@j-f1
Copy link
Collaborator Author

j-f1 commented Dec 17, 2018

Done @bradzacher

@bradzacher bradzacher merged commit 0d6794d into bradzacher:master Dec 17, 2018
@j-f1 j-f1 deleted the no-this-alias branch December 18, 2018 11:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@armano2 armano2 armano2 approved these changes

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j-f1 @armano2 @bradzacher